Remove the dead dep_gen guards left in the scheduler cold path - #1530
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughBoth scheduler cold-path variants remove the obsolete dep-gen collector include and no-op initialization branches. PMU initialization remains the active profiling setup where enabled. ChangesScheduler cold-path cleanup
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d49fc83 to
e83a5a0
Compare
dep_gen_aicpu_init() moved to the orchestrator thread (aicpu_executor.cpp)
so the schedulers no longer touch it. The two cold-path call sites were
emptied to `if (is_dep_gen_enabled()) {}` rather than removed, and the
comment above post_handshake_init still described the init() that popped
the initial free_queue buffer here — behaviour that no longer runs in
this file.
Drop both empty guards, the stale comment, and the now-unused
dep_gen_collector_aicpu.h include. No dep_gen symbol remains in either
scheduler_cold_path.cpp. a2a3 and a5 carry the identical arrangement and
are cleaned together.
1 participant
Summary
PR #1486 moved
dep_gen_aicpu_init()off the scheduler cold path and onto the orchestrator thread (aicpu_executor.cpp), but left the two cold-path call sites as emptyif (is_dep_gen_enabled()) {}shells instead of removing them. This cleans up the vestiges:if (is_dep_gen_enabled()) {}guards inpost_handshake_profiling_init()andpost_handshake_init().post_handshake_init()that still described theinit()popping the initial free_queue buffer here — that no longer runs in this file.#include "aicpu/dep_gen_collector_aicpu.h"; nodep_gensymbol remains in eitherscheduler_cold_path.cpp.a2a3 and a5 carried the identical arrangement and are cleaned together. Pure deletion,
SIMPLER_DFX-gated device code only — no behaviour change.Testing